Fix sphinx_rtd_theme theme override in embed js #1545
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The last refactor wasn't aware of the fact that the js Build class was modifying the actual config object in place. We are fixing this by using a getter method were the value is needed and are not mutating the original config object in place. Fixes #1542.
|
I've tested this locally with the |
ericholscher
added a commit
that referenced
this pull request
Aug 6, 2015
Fix sphinx_rtd_theme theme override in embed js
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The last refactor wasn't aware of the fact that the js Build class was modifying the actual config object in place. We are fixing this by using a getter method were the value is needed and are not mutating the original config object in place.
Fixes #1542.